8000 convert all source and scripts to ascii with LF EOL · Issue #4752 · PowerShell/PowerShell · GitHub
[go: up one dir, main page]
Skip to content

convert all source and scripts to ascii with LF EOL #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SteveL-MSFT opened this issue Sep 4, 2017 · 2 comments
Closed

convert all source and scripts to ascii with LF EOL #4752

SteveL-MSFT opened this issue Sep 4, 2017 · 2 comments
Labels
Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Resolution-Fixed The issue is fixed.
Milestone
6.1.0-Consider

Comments

@SteveL-MSFT
Copy link
Member

We have a number of strings that use the Copyright © symbol (0x00a9), but due to tools re-encoding files, the symbol gets mistranslated to the wrong unicode value. We should replace the text representation with the unicode value representation across all files. (Trademark character (0x2122) might also be used and should be replaced.
@SteveL-MSFT SteveL-MSFT added Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors labels Sep 4, 2017
@SteveL-MSFT SteveL-MSFT mentioned this issue Sep 4, 2017
Merged
@mklement0 mklement0 mentioned this issue Sep 6, 2017
Closed
mklement0 added a commit to mklement0/PowerShell that referenced this issue Sep 6, 2017
@mklement0
Implements PowerShell#4752 and more [feature]: line endings standardi…
588a3b8 
…zed, converted all file to BOM-less UTF-8
@SteveL-MSFT SteveL-MSFT self-assigned this Sep 14, 2017
@SteveL-MSFT SteveL-MSFT removed the Up-for-Grabs Up-for-grabs issues are not high priorities, and may be opportunities for external contributors label Sep 14, 2017
@SteveL-MSFT SteveL-MSFT changed the title replace printed version of trademark/copyright character with unicode value convert all source and scripts to ascii with LF EOL Sep 27, 2017
@SteveL-MSFT SteveL-MSFT added this to the 6.1.0 milestone Sep 27, 2017
@SteveL-MSFT SteveL-MSFT removed their assignment Sep 27, 2017
@SteveL-MSFT
Copy link
Member Author

Copyright header was addressed by #6134

@SteveL-MSFT
Copy link
Member Author

We made changes to gitattributes and vscode config so EOL should be fixed over time

@iSazonov iSazonov added the Resolution-Fixed The issue is fixed. label Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Code Cleanup the issue is for cleaning up the code with no impact on functionality Resolution-Fixed The issue is fixed.
Projects
None yet
Milestone
6.1.0-Consider
Development

No branches or pull requests
2 participants
@SteveL-MSFT @iSazonov
0