Fix and enhance mulitple quoted string issues #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves double-quote double-quote escape from #doubleQuotedStringEscapes to #doubleQuotedString. Removes the single-quote single-quote escape from single-quote here-string pattern.
permits whitespace to follow here-string start token.
indirectly applies PowerShell#167 parts 2 and 3
adds punctuation scope to start/end of here-string
Merged
rjmholt
approved these changes
Mar 12, 2021
andyleejordan
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Double doublequotes in here-string scopes as a character.escape #143, moving the double double-quote escape (
"") in todoubleQuotedStringfromdoubleQuotedStringEscapes, and removing the double single-quote escape ('') from the pattern for single quoted here-strings.Fixes Quoted strings/here-strings issues #167 (entirely), permitting white space to follow the opening token for here-strings, adding punctuation scopes to the start and end tokens (
punctuation.definition.string…), and preparing some of the string regex's for the following change.Closes Account for curly quotes in syntax definition. #141, applying the PowerShell supported curly quotes
\x{2018}-\x{201B}(single quotes) and\x{201C}-\x{201E}(double quotes), everywhere except for an occurrence inhashtable:EditorSyntax/PowerShellSyntax.tmLanguage
Lines 1501 to 1504 in 44eac87
There are issues in this area, that nearly make the quotes in this section unusable.
Tests added for single quoted here-string, and the escaping issue of Double doublequotes in here-string scopes as a character.escape #143. There are currently no tests I found for
punctuation.definition.string…for any kind of strings.