8000 feat: fetch all expansions by iGabyTM · Pull Request #952 · PlaceholderAPI/PlaceholderAPI · GitHub
[go: up one dir, main page]

Skip to content

feat: fetch all expansions#952

Merged
iGabyTM merged 3 commits intomasterfrom
feature/fetch-all-expansions
Jun 21, 2023
Merged

feat: fetch all expansions#952
iGabyTM merged 3 commits intomasterfrom
feature/fetch-all-expansions

Conversation

@iGabyTM
Copy link
Member
@iGabyTM iGabyTM commented Apr 5, 2023

Fetch all expansions and display a different message if the expansion that the player is trying to download is not verified and cloud_allow_unverified_expansions is false

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

Closes N/A

and display a different message if the expansion th
8000
at the player is trying to download is not verified and `cloud_allow_unverified_expansions` is false
@iGabyTM iGabyTM added Type: Enhancement New feature or request Target: Code This issue/PR is targeting the Code of PlaceholderAPI labels Apr 5, 2023
@Funny-cube
Copy link 10BC0
Member

Suggest using https://placeholderapi.com/ecloud as the url so we can redirect if needed in the future

@iGabyTM
Copy link
Member Author
iGabyTM commented Apr 22, 2023

Suggest using placeholderapi.com/ecloud as the url so we can redirect if needed in the future

Looks like the redirect is not setup right, /javascript redirects to https://api.extendedclip.com/home//javascript - notice the double /

@iGabyTM iGabyTM requested a review from Funny-cube June 20, 2023 15:41
@iGabyTM iGabyTM merged commit f91b4e3 into master Jun 21, 2023
@iGabyTM iGabyTM deleted the feature/fetch-all-expansions branch June 21, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0