8000 fix: catch NoClassDefFoundError in order for the other expansions to be loaded by iGabyTM · Pull Request #936 · PlaceholderAPI/PlaceholderAPI · GitHub
[go: up one dir, main page]
Skip to content

fix: catch NoClassDefFoundError in order for the other expansions to be loaded#936

Merged
darbyjack merged 3 commits intomasterfrom
fix/missing-class-exception-breaks-expansion-loading
Mar 17, 2023
Merged

fix: catch NoClassDefFoundError in order for the other expansions to be loaded#936
darbyjack merged 3 commits intomasterfrom
fix/missing-class-exception-breaks-expansion-loading

Conversation

@iGabyTM
Copy link
Member
@iGabyTM iGabyTM commented Mar 17, 2023 •
edited
Loading

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

Currently if an expansion throws that exception no expansion is loaded

Closes N/A

@iGabyTM iGabyTM added Type: Enhancement New feature or request Target: Code This issue/PR is targeting the Code of PlaceholderAPI labels Mar 17, 2023
@darbyjack darbyjack merged commit 81ef464 into master Mar 17, 2023
@darbyjack darbyjack deleted the fix/missing-class-exception-breaks-expansion-loading branch March 17, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darbyjack darbyjack darbyjack approved these changes

@PiggyPiglet PiggyPiglet Awaiting requested review from PiggyPiglet PiggyPiglet is a code owner

Assignees

No one assigned

Labels

Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iGabyTM @darbyjack
0