python 3.13 #1
Open
python 3.13 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request updates the dependency_injector library to support Python 3.13 and removes support for older Python versions. It simplifies import statements, removes version-specific code, and updates CI configurations. Updated architecture diagram for CI configurationgraph TD;
A[CI Configuration] -->|Python 3.9| B[Tests and Linters];
A -->|Python 3.10| B;
A -->|Python 3.11| B;
A -->|Python 3.12| B;
A -->|Python 3.13| B;
Updated class diagram for providers moduleclassDiagram
class Dependency {
-set_instance_of(instance_of)
}
class Coroutine {
-set_provides(provides)
}
class ConfigurationOption {
-Error
}
class Configuration {
-Error
}
class Resource {
-_is_resource_subclass(instance)
-_is_async_resource_subclass(instance)
}
class is_provider {
-instance
}
class is_delegated {
-instance
}
class is_container_instance {
-instance
}
class is_container_class {
-instance
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @Pentusha - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding upgrade instructions or a migration guide in the documentation to help users transition from older Python versions to 3.9+ as support for earlier versions has been dropped.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| Please use the [documentation](https://python-dependency-injector.ets-labs.org/) of the original library. | ||
| Please use the [documentation](https://python-dependency-injector.ets-labs.org/) of the original library. | ||
|
|
||
| I also suggest looking into the excellent [that-depends](https://github.com/modern-python/that-depends) library, |
There was a problem hiding this comment.
question (documentation): Consider if suggesting alternative libraries is appropriate for this README.
While this information could be valuable for users, it's somewhat unusual to recommend other libraries in a project's README. Ensure this aligns with your intended documentation strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Drop support for Python 2 and older Python 3 versions, and add support for Python 3.13. Update the codebase to remove compatibility checks and deprecated warnings related to older Python versions. Adjust the CI configuration to test against Python 3.13 and update documentation to reflect these changes.
Enhancements:
Build:
CI:
Documentation: