Separate Command Sending to Separate Thread Pool #8170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
767cdd4 to
1643ba9
Compare
darbyjack
approved these changes
Aug 7, 2022
electronicboy
approved these changes
Aug 8, 2022
1643ba9 to
98dd9d8
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://canary.discord.com/channels/289587909051416579/925530366192779286/999447366639829093
I'm not sure if I should shutdownNow or wait, would like feedback here.
But basically, the idea is to shutdown and stop command sending from being done async and not being closed till very later in the server saving process.
There might be more as to what is causing exceptions like this, but shutting it down might be fine here?