make each project a workspace #3
Conversation
This fixes the error "current package believes it's in a workspace", if the repository was cloned inside the directory structure of another workspace, as explained in cargo issue 5418. It doesn't affect anything else and will make the projects compile more reliably under those special conditions.
|
Thank you for submitting and suggesting this change. I'm reluctant to make so big changes at this point since I've been testing everything extensively until the release and won't risk doing anything without testing everything again. This all seems good, though, and I can't see any problems with it. I'll leave the PR here so I can include it if and when I make larger changes and re-test everything at a later point. Does cloning the repository into an existing workspace have any advantages that I might be unaware of? |
|
No advantage in cloning a repository inside an existing workspace, just that if you choose to do so you encounter that error. This happens to me sometimes. And since this project has a lot of nested manifest files I thought it could be nice to prevent that problem from arising for any other readers. Of course the simple solution is to clone/move the project's directory elsewhere, and one can also modify the manifests recursively with a one-liner like: Please feel free to close this if you think it's more noise than signal |
|
Thanks for being patient. Let's keep this open for now, maybe there are others in the same situation and while I'm a little bit reluctant to make significant changes at the moment, I see no problem of adding this in the future. |
This fixes the error "current package believes it's in a workspace", if the repository was cloned inside the directory structure of another workspace, as explained in cargo issue 5418.
It doesn't affect anything else and will make the projects compile more reliably under those special conditions.