Arg depend #369
Merged
Arg depend #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up custom Azure Resource Graph helpers by leveraging the official AzResourceGraph module, standardizes the tenant parameter name, and documents a new Disconnect-Bicep cmdlet.
- Updated module dependencies and removed private Graph functions
- Renamed TenantId to Tenant in Connect-Bicep and its tests
- Added help file for Disconnect-Bicep
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Connect-Bicep.Tests.ps1 | Updated assertions and test titles to use the renamed Tenant param |
| Source/Public/Export-BicepResource.ps1 | Replaced custom Search-AzureResourceGraph with Search-AzResourceGraph |
| Source/Public/Connect-Bicep.ps1 | Changed TokenSplat key from TenantId to Tenant |
| Source/Private/WriteErrorStream.ps1 | Removed unused helper function |
| Source/Private/Search-AzureResourceGraph.ps1 | Removed unused helper function |
| Source/Private/GetAzResourceGraphPage.ps1 | Removed unused helper function |
| RequiredModules.psd1 | Bumped AzAuth to 2.6.0 and added AzResourceGraph dependency |
| Docs/Help/Disconnect-Bicep.md | Added documentation for the new Disconnect-Bicep cmdlet |
| CHANGELOG.md | Documented removal of private Graph functions |
| .github/actions/build/action.yml | Adjusted SemVer formatting logic |
Comments suppressed due to low confidence (4)
Docs/Help/Disconnect-Bicep.md:41
- The OUTPUTS section lists System.Object, but Disconnect-Bicep does not emit any objects. Update this to 'None' or clarify what (if anything) is returned.
### System.Object
Tests/Connect-Bicep.Tests.ps1:95
- [nitpick] The test description uses 'certstore' as a single word; consider changing to 'certificate store' for consistency and clarity.
It 'Should connect using Certificate as path to certstore' {
Tests/Connect-Bicep.Tests.ps1:1
- There are no unit tests covering the new Disconnect-Bicep cmdlet. Consider adding tests to verify that session data and cached tokens are cleared appropriately.
BeforeAll {
Contributor
Linux Test Results 1 files ±0 61 suites ±0 5s ⏱️ ±0s Results for commit 685bba0. ± Comparison against base commit f578f05. This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both. |
Contributor
Win Test Results 1 files ±0 61 suites ±0 5s ⏱️ ±0s Results for commit 685bba0. ± Comparison against base commit f578f05. This pull request removes 4 and adds 2 tests. Note that renamed tests count towards both. |
PalmEmanuel
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the repository, focusing on improving module dependencies, removing unused private functions, enhancing session management, and updating tests for consistency. Below is a categorized summary of the most important changes:
Dependency Updates
AzAuthmodule version from2.4.0to2.6.0inRequiredModules.psd1. Added dependency onAzResourceGraphmodule with version0.2.1.Code Cleanup
WriteErrorStream,GetAzResourceGraphPage, andSearch-AzureResourceGraph.Export-BicepResourcefunction to useSearch-AzResourceGraphinstead of the removedSearch-AzureResourceGraph.New Features
Disconnect-BicepTest Updates
Connect-Bicepto reflect the property name change fromTenantIdtoTenantand clarified descriptions for certificate path tests.As part of this Pull Request I have
mainbranch