TST: add SkylakeX AVX512 CI test #2134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapt the C-level reproducer code for some
recent SkylakeX AVX512 kernel issues, provided
by Isuru Fernando and modified by Martin Kroeker,
for usage in the utest suite
add an Intel SDE SkylakeX emulation utest run to
the Azure CI matrix; a custom Docker build was required
because Ubuntu image provided by Azure does not support
AVX512VL instructions
If you're 8000 like me and don't believe regression tests until you've seen the failure, here's the same CI run on a branch off OpenBLAS at 3f427c0, the most problematic recent build used in NumPy ecosystem. After demonstrating that failure, I ported the relevant changes over to this PR branch.
The hope is that this can supersede the Intel SDE skx regression guards for:
and provide a faster feedback loop in SkylakeX AVX512 kernel issues directly / automatically at the source, rather than downstream.
This took rather longer to draft than I had hoped--one unfortunate issue is the way we
echo
to Dockerfiles rather than just putting well-formatted Dockerfiles into the repo proper, and the fact thatdocker build
doesn't support--privileged
as required for SDE process attachment.Of course, there are still a few issues open about SkylakeX AVX512 matters, so this may simply be the start of related regression guards. And as Isuru previously noted, BLIS actually iterates over a few different emulation archs, so you / we might consider building up to that I suppose.