8000 TST: add SkylakeX AVX512 CI test by tylerjereddy · Pull Request #2134 · OpenMathLib/OpenBLAS · GitHub
[go: up one dir, main page]

Skip to content

TST: add SkylakeX AVX512 CI test #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tylerjereddy
Copy link
Contributor
@tylerjereddy tylerjereddy commented May 14, 2019
  • adapt the C-level reproducer code for some
    recent SkylakeX AVX512 kernel issues, provided
    by Isuru Fernando and modified by Martin Kroeker,
    for usage in the utest suite

  • add an Intel SDE SkylakeX emulation utest run to
    the Azure CI matrix; a custom Docker build was required
    because Ubuntu image provided by Azure does not support
    AVX512VL instructions

If you're 8000 like me and don't believe regression tests until you've seen the failure, here's the same CI run on a branch off OpenBLAS at 3f427c0, the most problematic recent build used in NumPy ecosystem. After demonstrating that failure, I ported the relevant changes over to this PR branch.

The hope is that this can supersede the Intel SDE skx regression guards for:

and provide a faster feedback loop in SkylakeX AVX512 kernel issues directly / automatically at the source, rather than downstream.

This took rather longer to draft than I had hoped--one unfortunate issue is the way we echo to Dockerfiles rather than just putting well-formatted Dockerfiles into the repo proper, and the fact that docker build doesn't support --privileged as required for SDE process attachment.

Of course, there are still a few issues open about SkylakeX AVX512 matters, so this may simply be the start of related regression guards. And as Isuru previously noted, BLIS actually iterates over a few different emulation archs, so you / we might consider building up to that I suppose.

* adapt the C-level reproducer code for some
recent SkylakeX AVX512 kernel issues, provided
by Isuru Fernando and modified by Martin Kroeker,
for usage in the utest suite

* add an Intel SDE SkylakeX emulation utest run to
the Azure CI matrix; a custom Docker build was required
because Ubuntu image provided by Azure does not support
AVX512VL instructions
@martin-frbg
Copy link
Collaborator

Of course, there are still a few issues open about SkylakeX AVX512 matters

Are there additional issues in numpy/scipy that are related to OpenBLAS SKX kernels apart from DGEMM ?

@tylerjereddy
Copy link
Contributor Author

Are there additional issues in numpy/scipy that are related to OpenBLAS SKX kernels apart from DGEMM ?

As of 6a8b426, both NumPy and SciPy full linear algebra test suites pass--I'm planning to use that commit to distribute with the final wheels for SciPy 1.3.0. So that's great!

I meant that there are more issues open to OpenBLAS itself about SKX and that there is at least a chance that some of them might be slightly different targets than the C reproducer used here? Maybe I'm wrong on that--the various discussions seem complicated by difficulties with reproduction.

As noted previously, when you deactivated the skx AVX512 kernels more selectively there was an uptick in NumPy skx test failures, and then the more comprehensive deactivation allowed the full linear algebra suite to pass.

@tylerjereddy
Copy link
Contributor Author

looks like an unrelated timeout on the mac job

@martin-frbg martin-frbg merged commit d8d5682 into OpenMathLib:develop May 15, 2019
@tylerjereddy tylerjereddy deleted the skylake_regress_guard_may14 branch May 15, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0