Supports query params without values#193
Merged
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom Feb 21, 2015
jebeaudet:fix-NPEOnEmptyQueryParam
Merged
Supports query params without values#193codefromthecrypt merged 1 commit intoOpenFeign:masterfrom jebeaudet:fix-NPEOnEmptyQueryParam
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom
jebeaudet:fix-NPEOnEmptyQueryParam
Conversation
Fixes NPE when building a client with a query param with no values
|
NetflixOSS » feign » feign-pull-requests #61 SUCCESS |
Contributor
|
Looks beautiful |
codefromthecrypt
pushed a commit
that referenced
this pull request
Feb 21, 2015
Supports query params without values
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Supports query params without values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update of the PR #192 that was incomplete, thanks for the tips!
I added tests to validate the changes and discovered some more changes had to be made. Sorry about yesterday's incomplete PR, I should have added tests from the beginning.
Hope this one is OK, let me know if there is anything I can do to improve it.