Makes body parameter type explicit#155
Merged
codefromthecrypt merged 1 commit intomasterfrom Jan 31, 2015
Merged
Conversation
Feign has `MethodMetadata.bodyType()`, but never passed it to encoders. Encoders that register type adapters need to do so based on the interface desired as opposed to the implementation class. This change breaks api compatibility for < 8.x, by requiring an additional arg on `Encoder.encode`. see square/retrofit#713
Contributor
Author
There was a problem hiding this comment.
lots of reformatting on jaxb as the inconsistent indent was driving me bonkers.
|
NetflixOSS » feign » feign-pull-requests #39 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jan 31, 2015
Makes body parameter type explicit
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Makes body parameter type explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feign has
MethodMetadata.bodyType(), but never passed it to encoders.Encoders that register type adapters need to do so based on the
interface desired as opposed to the implementation class. This change
breaks api compatibility for < 8.x, by requiring an additional arg
on
Encoder.encode.see square/retrofit#713