Removes guava test dependency in favor of AssertJ#144
Merged
codefromthecrypt merged 1 commit intomasterfrom Jan 26, 2015
Merged
Removes guava test dependency in favor of AssertJ#144codefromthecrypt merged 1 commit intomasterfrom
codefromthecrypt merged 1 commit intomasterfrom
Conversation
AssertJ has more powerful test assertions and does not run the risk of interfering with the classpath of main code, such as guava does. This removes guava from test and example code and adjusts using AssertJ in some cases.
5456763 to
3fc385a
Compare
|
NetflixOSS » feign » feign-pull-requests #13 SUCCESS |
codefromthecrypt
pushed a commit
that referenced
this pull request
Jan 26, 2015
Removes guava test dependency in favor of AssertJ
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Removes guava test dependency in favor of AssertJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssertJ has more powerful test assertions and does not run the risk of
interfering with the classpath of main code, such as guava does. This
removes guava from test and example code and adjusts using AssertJ in
some cases.
Note: this is the last cleanup before doing real work again :)