8000 Removes Dagger 1.x Dependency by codefromthecrypt · Pull Request #141 · OpenFeign/feign · GitHub
[go: up one dir, main page]
Skip to content

Removes Dagger 1.x Dependency#141

Merged
codefromthecrypt merged 2 commits intomasterfrom
adrian.no-dagger
Jan 26, 2015
Merged

Removes Dagger 1.x Dependency#141
codefromthecrypt merged 2 commits intomasterfrom
adrian.no-dagger

Conversation

@codefromthecrypt
Copy link
Contributor
@codefromthecrypt codefromthecrypt commented Jan 24, 2015

Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

see #120

@codefromthecrypt
Copy link
Contributor Author
codefromthecrypt commented Jan 24, 2015

cc @allenxwang @Randgalt @davidmc24

@codefromthecrypt codefromthecrypt force-pushed the adrian.no-dagger branch 2 times, most recently from f8a46e9 to 4f755f2 Compare January 24, 2015 17:52
@codefromthecrypt
Copy link
Contributor Author
codefromthecrypt commented Jan 24, 2015

also cc @qualidafial

codefromthecrypt
codefromthecrypt reviewed Jan 24, 2015
View reviewed changes
README.md
Copy link
Contributor Author
@codefromthecrypt codefromthecrypt Jan 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to the bottom, as it is more advanced.

dagger.gradle
Copy link
Contributor Author
@codefromthecrypt codefromthecrypt Jan 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @cfieber no longer needed, but.. may be resurrected if another annotation processor is added, such as auto-value

@codefromthecrypt
Copy link
Contributor Author
codefromthecrypt commented Jan 24, 2015

ps here's the blog I wrote which also motivated me to do this https://medium.com/@adrianfcole/no-di-is-dumb-perhaps-dumber-than-mandating-a-specific-injector-7b5faa34a8eb

@spencergibb
Copy link
Contributor
spencergibb commented Jan 25, 2015

Big 👍

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jan 26, 2015

NetflixOSS » feign » feign-pull-requests #14 SUCCESS
This pull request looks good

@codefromthecrypt codefromthecrypt added this to the 8.0.0 milestone Jan 26, 2015
@codefromthecrypt
Copy link
Contributor Author
codefromthecrypt commented Jan 26, 2015

ok ready to go!

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jan 26, 2015

NetflixOSS » feign » feign-pull-requests #18 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jan 26, 2015

NetflixOSS » feign » feign-pull-requests #25 SUCCESS
This pull request looks good

Adrian Cole added 2 commits January 26, 2015 10:13
Removes Dagger 1.x Dependency and support for javax.inject.Named
8a0cba5 
Dagger 1.x and 2.x are incompatible. Rather than choose one over the
other, this change removes Dagger completely. Users can now choose any
injector, constructing Feign via its Builder.

This change also drops support for javax.inject.Named, which has
been replaced by feign.Param.

see #120
Removes unused imports in OkHttpClientTest
bceee32
codefromthecrypt pushed a commit that referenced this pull request Jan 26, 2015
@adriancole
Merge pull request #141 from Netflix/adrian.no-dagger
4323d6a 
Removes Dagger 1.x Dependency
@codefromthecrypt codefromthecrypt merged commit 4323d6a into master Jan 26, 2015
@codefromthecrypt codefromthecrypt deleted the adrian.no-dagger branch January 26, 2015 18:15
@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jan 26, 2015

NetflixOSS » feign » feign-pull-requests #26 FAILURE
Looks like there's a problem with this pull request

@codefromthecrypt
Copy link
Contributor Author
codefromthecrypt commented Jan 26, 2015

@rspieldenner do you mind publishing 8.0.0-rc1 from master?

  • done

@rspieldenner
Copy link
Contributor
rspieldenner commented Jan 26, 2015

shall do once pull request likes it -- which looks like something on the build end or at least cloudbees end

@codefromthecrypt codefromthecrypt restored the adrian.no-dagger branch January 26, 2015 18:23
@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jan 26, 2015

NetflixOSS » feign » feign-pull-requests #27 SUCCESS
This pull request looks good

@codefromthecrypt
Copy link
Contributor Author
codefromthecrypt commented Jan 26, 2015

transient build fail!

This was referenced Jan 26, 2015
Closed
Closed
@davidmc24
Copy link
Contributor
davidmc24 commented Jan 26, 2015

@adriancole Looks good to me.

@velo velo deleted the adrian.no-dagger branch May 5, 2018 22:31
velo pushed a commit that referenced this pull request Oct 8, 2024
@adriancole
Merge pull request #141 from Netflix/adrian.no-dagger
7bd4e57 
Removes Dagger 1.x Dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@codefromthecrypt @spencergibb @cloudbees-pull-request-builder @rspieldenner @davidmc24
0