Conversation
Hi. In JAX-RS section, adding 'JAXRSContract' is omitted. So, I didn't understand the JAX-RS example correctly. And I got an exception when I run it. If adding 'JAXRSContract' is added, It is helpful to beginners like me. Thank you.
|
NetflixOSS » feign » feign-pull-requests #1 SUCCESS |
|
Looks good, but let's try to keep the fole as short as possible. I think lines 149-152 are the most essential to add. Do you agree? |
I removed the unessential lines. Thanks for your advice.
|
Yes, I do. |
|
NetflixOSS » feign » feign-pull-requests #2 SUCCESS |
Remove more lines for unity? consistency. Customization, Request Interceptors, are written as this form.
|
NetflixOSS » feign » feign-pull-requests #3 SUCCESS |
README.md
Outdated
There was a problem hiding this comment.
Tip If you append java to the triple backquote, it will format nicely.
There was a problem hiding this comment.
Last nit: I would still retain newlines after the call to each builder. Some mobile viewers will see an awkward wrap otherwise.
There was a problem hiding this comment.
Did you mean this ? Two java code blocks and retaining newlines.
I need to study English more. T.T
interface GitHub {
@GET @Path("/repos/{owner}/{repo}/contributors")
List<Contributor> contributors(@PathParam("owner") String owner, @PathParam("repo") String repo);
}GitHub github = Feign.builder()
.contract(new JAXRSModule.JAXRSContract())
.target(GitHub.class, "https://api.github.com"); In JAX-RS example, two Java code blocks and retaining new lines after the call to each builder.8000
|
NetflixOSS » feign » feign-pull-requests #4 SUCCESS |
|
Thanks! |
|
You're welcome ~ |
Hi.
In JAX-RS section, adding 'JAXRSContract' is omitted.
So, I didn't understand the JAX-RS example correctly. And I got an exception when I run it.
If adding 'JAXRSContract' is added, It is helpful to beginners like me.
Thank you.