E530 Added JAXB Codec by gregwhitaker · Pull Request #116 · OpenFeign/feign · GitHub
[go: up one dir, main page]
Skip to content

Added JAXB Codec#116

Merged
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom
gregwhitaker:jaxb-support
Oct 22, 2014
Merged

Added JAXB Codec#116
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom
gregwhitaker:jaxb-support

Conversation

@gregwhitaker
Copy link
Contributor
@gregwhitaker gregwhitaker commented Jul 18, 2014

Added support for encoding and decoding XML responses with JAXB.

Opened a new pull request with the squashed commits.

codefromthecrypt
codefromthecrypt reviewed Jul 18, 2014
View reviewed changes
jaxb/README.md Outdated
Copy link
Contributor
@codefromthecrypt codefromthecrypt Jul 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to the javadoc please!

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jul 18, 2014

ok, just a couple small this.

ps. in the future, please force push your branch to squash as opposed to duplicating issues. Duplicating issues clutters the issue log.

Ex.

git rebase -i master
# squash commits
git push -f origin jaxb-support

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jul 18, 2014

feign-pull-requests #168 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jul 20, 2014

feign-pull-requests #169 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jul 21, 2014

feign-pull-requests #170 FAILURE
Looks like there's a problem with this pull request

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jul 21, 2014

Looks like you managed to get it squashed. The commit message isn't useful, so if you could reword it to "added support for jaxb" or similar, we may be good to go!

I haven't looked into the build fail tho.

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jul 21, 2014

feign-pull-requests #171 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jul 21, 2014

feign-pull-requests #172 FAILURE
Looks like there's a problem with this pull request

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jul 21, 2014

just kicking the PR to deflake the buildhive job

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Jul 21, 2014

feign-pull-requests #173 FAILURE
Looks like there's a problem with this pull request

@codefromthecrypt
Copy link
Contributor
codefromthecrypt commented Jul 21, 2014

@allenxwang can you help clear out the buildhive workspace? I think this
should not be failing, and seems login is restricted to netflix domain.

@cloudbees-pull-request-builder
Copy link
cloudbees-pull-request-builder commented Oct 22, 2014

feign-pull-requests #179 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request Oct 22, 2014
@adriancole
Merge pull request #116 from gregwhitaker/jaxb-support
98d0423 
Added JAXB Codec
@codefromthecrypt codefromthecrypt merged commit 98d0423 into OpenFeign:master Oct 22, 2014
velo pushed a commit that referenced this pull request Oct 8, 2024
@adriancole
Merge pull request #116 from gregwhitaker/jaxb-support
604522c 
Added JAXB Codec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gregwhitaker @codefromthecrypt @cloudbees-pull-request-builder
0