8000 Make build work with java 8. by codefromthecrypt · Pull Request #108 · OpenFeign/feign · GitHub
[go: up one dir, main page]

Skip to content

Make build work with java 8.#108

Merged
codefromthecrypt merged 1 commit intomasterfrom
adrian.java8
May 25, 2014
Merged

Make build work with java 8.#108
codefromthecrypt merged 1 commit intomasterfrom
adrian.java8

Conversation

@codefromthecrypt
Copy link
Contributor

cc @quidryan @allenxwang

p.s. is it ok to update deps? most are out of date and some are really out of date (ex. guava)

@cloudbees-pull-request-builder

feign-pull-requests #150 SUCCESS
This pull request looks good

@codefromthecrypt
< 8000 div class="d-flex flex-row-reverse flex-items-center flex-shrink-0 tmp-pl-3">
Copy link
Contributor Author

cc @rspieldenner

@rspieldenner
Copy link
Contributor

As far as I can tell Gradle 1.12 breaks our OSS publishing right now. I think anything newer than 1.6 or 1.7 does.

@codefromthecrypt
Copy link
Contributor Author

@rspieldenner oh.. I saw a note from @benjchristensen which seemed to imply things fixed in 1.12.. maybe it was a fix to a different problem?

@codefromthecrypt codefromthecrypt changed the title Make build work with latest intellij and java 8. Make build work with java 8. May 25, 2014
@codefromthecrypt
Copy link
Contributor Author

ok I removed the gradle update. I forgot we don't really need it in intellij anyway due to us generating the project via ./gradlew cleanIdea idea

@cloudbees-pull-request-builder

feign-pull-requests #151 SUCCESS
This pull request looks good

codefromthecrypt pushed a commit that referenced this pull request May 25, 2014
Make build work with java 8.
@codefromthecrypt codefromthecrypt merged commit 9efe940 into master May 25, 2014
@codefromthecrypt codefromthecrypt deleted the adrian.java8 branch May 25, 2014 18:23
velo pushed a commit that referenced this pull request Oct 8, 2024
Make build work with java 8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0