8000 Support language N4JS by mmews-n4 · Pull Request #15089 · OpenAPITools/openapi-generator · GitHub
[go: up one dir, main page]
Skip to content

Support language N4JS #15089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 3, 2023
Merged

Support language N4JS #15089

merged 18 commits into from
May 3, 2023

Conversation

mmews-n4
Copy link
Contributor
@mmews-n4 mmews-n4 commented Mar 31, 2023 •
edited
Loading

This PR is the initial commit to enable client generator support for language N4JS. N4JS is a JavaScript based language that adds a sophisticated type model and other features. It can be compared to TypeScript. More details of language N4JS can be found at n4js.org.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script : 
    ./bin/utils/ensure-up-to-date.sh
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Note

  • The scripts above (./bin/utils/export_docs_generators.sh, ./bin/utils/ensure-up-to-date.sh) do generate changes on 1000+ files that are unrelated to this PR but are instead related to generators of other languages like Java Springboot, Python, etc. These unrelated changes are not part of this PR.

@mmews-n4 mmews-n4 marked this pull request as ready for review March 31, 2023 15:16
@wing328 wing328 added this to the 6.6.0 milestone Apr 13, 2023
wing328
wing328 reviewed Apr 13, 2023
View reviewed changes
...penapi-generator/src/test/java/org/openapitools/codegen/n4js/N4jsClientCodegenModelTest.java Outdated
import io.swagger.v3.parser.util.SchemaTypeUtil;

@SuppressWarnings("deprecation")
public class N4jsClientCodegenModelTest {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmews-n4 thanks for the PR.

looks like this test file is a just copy of another test file?

if that's the case, I don't think we need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe t 8000 his comment to others. Learn more.

@wing328 Thanks for your review!

Right, this was a copy from js, since JavaScript is very similar to N4JS. I removed it as you said.

@wing328
Copy link
Member
wing328 commented Apr 13, 2023

The scripts above (./bin/utils/export_docs_generators.sh, ./bin/utils/ensure-up-to-date.sh) do generate changes on 1000+ files that are unrelated to this PR but are instead related to generators of other languages like Java Springboot, Python, etc. These unrelated changes are not part of this PR.

I took a look and could repeat such behaviour locally. Not sure why. Will try to investigate further this weekend.

@mmews-n4
Copy link
Contributor Author
mmews-n4 commented May 2, 2023

I merged master to keep this PR up-to-date. Please note that I find the reason for the failing CI builds to be unrelated with this PR. However, in case it is actually related to this PR, please let me know how I can improve this. Thank you!

@wing328
Copy link
Member
wing328 commented May 3, 2023

LGTM. I'll file a separate PR to improve it after merging this one.

@wing328 wing328 merged commit a834700 into OpenAPITools:master May 3, 2023
@mmews-n4
Copy link
Contributor Author
mmews-n4 commented May 3, 2023

Thank you!

@wing328
Copy link
Member
wing328 commented May 3, 2023

@mmews-n4 can you please PM me via Slack at your earliest convenience?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

wing328 added a commit that referenced this pull request May 3, 2023
@wing328
Revert "Support language N4JS (#15089)"
e700543 
This reverts commit a834700.
@wing328 wing328 mentioned this pull request May 3, 2023
Merged
wing328 added a commit that referenced this pull request May 3, 2023
@wing328
Revert "Support language N4JS (#15089)" (#15396)
aea7cef 
This reverts commit a834700.
@wing328
Copy link
Member
wing328 commented May 3, 2023

@mmews-n4 sorry I've to revert the change for now. Please ping me via Slack to discuss further.

@mmews-n4 mmews-n4 mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing328 wing328 wing328 left review comments

Assignees
No one assigned
Labels
Client: N4JS Enhancement: New generator
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mmews-n4 @wing328
0