-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go] Generate test files #13560
[Go] Generate test files #13560
Conversation
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/GoClientCodegen.java
Outdated
Show resolved
Hide resolved
LGTM. Thanks for the enhancement. |
We've noticed this change seems to create a broken import error. Not sure if this is a bug or if we're doing something wrong. |
@janhartigan Uhm, I think you are right, I am going to have a look (the import should use the module name) |
@janhartigan What is in the generated |
|
@wing328 I have created a new PR #13905 to address this @janhartigan This is now corrected, thanks for pointing it out. Meanwhile (if it helps) you can fix this manually in the generated test file(s) correcting the import with:
|
@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)
Updated Go codegen to generate the test files as well, adding a new
api_test.mustache
. See #13559.I have provided a basic implementation of a test, and added the skip option by default (I think it is very helpful to have a basic test implementation to start with, which can be extended and enabled by developer)
How to validate
Generate Go client and verify the test files have been created
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)