[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Generate test files #13560

Merged
merged 6 commits into from
Oct 7, 2022
Merged

Conversation

gcatanese
Copy link
Contributor

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04)

Updated Go codegen to generate the test files as well, adding a new api_test.mustache. See #13559.

I have provided a basic implementation of a test, and added the skip option by default (I think it is very helpful to have a basic test implementation to start with, which can be extended and enabled by developer)

How to validate

Generate Go client and verify the test files have been created

java -jar /openapi-generator/modules/openapi-generator-cli/target/openapi-generator-cli.jar  generate \
-i openapi.yaml -g go  -p packageName=Management -o src/folder

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member
wing328 commented Oct 7, 2022

LGTM. Thanks for the enhancement.

@wing328 wing328 merged commit 48928d8 into OpenAPITools:master Oct 7, 2022
@janhartigan
Copy link

@gcatanese @wing328

We've noticed this change seems to create a broken import error. Not sure if this is a bug or if we're doing something wrong.

Screen Shot 2022-11-01 at 15 45 56

@gcatanese
Copy link
Contributor Author

@janhartigan Uhm, I think you are right, I am going to have a look (the import should use the module name)

@gcatanese
Copy link
Contributor Author

@janhartigan What is in the generated go.mod?

@janhartigan
Copy link

@gcatanese

module github.com/goartica/product-service-northstar-go-client

go 1.13

require (
	github.com/stretchr/testify v1.4.0
	golang.org/x/oauth2 v0.0.0-20210323180902-22b0adad7558
)

@gcatanese
Copy link
Contributor Author

@wing328 I have created a new PR #13905 to address this

@janhartigan This is now corrected, thanks for pointing it out. Meanwhile (if it helps) you can fix this manually in the generated test file(s) correcting the import with:

openapiclient "github.com/GIT_USER_ID/GIT_REPO_ID"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants