Fix bug caused by System.Threading.Tasks v4.7.1
#892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyleejordan
commented
Oct 5, 2022
| @@ -14,7 +14,6 @@ | |||
| <PackageReference Include="JetBrains.ReSharper.CommandLineTools" ExcludeAssets="All" /> | |||
| <PackageReference Include="GitVersion.Tool" ExcludeAssets="All" /> | |||
| <PackageReference Include="ReportGenerator" ExcludeAssets="All" /> | |||
| <PackageReference Include="JetBrains.ReSharper.CommandLineTools" ExcludeAssets="All" /> | |||
There was a problem hiding this comment.
I removed this because it was a duplicate line and the build tools complained about it. (See line 14.)
andyleejordan
commented
Oct 5, 2022
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="../../src/Server/Server.csproj" /> | |||
| <PackageReference Include="Microsoft.Extensions.Logging" VersionOverride="3.0.0" /> | |||
There was a problem hiding this comment.
The sample project was failing to restore because its dependencies updated to 6.0.0, but it was not.
…ence This line was a duplicate and the build tools complained about it.
In order to allow it to restore since this dependency was updated upstream, and that was causing it to fail to restore due to the detected forced downgrade.
Unfortunately `System.Threading.Tasks` v4.7.1 is broken. Its package manifest states that it depends on `System.Threading.Tasks.Extensions` >= v4.5.4 (assembly version v4.2.0.1); however, for some reason it actually requests v4.2.0.0. While neither OmniSharp nor PowerShell Editor Services, the downstream library where this bug appeared, ship that version of the library, it can sometimes be found in the Global Assembly Cache on Windows. When present (due to an installation by some other program), it gets loaded, and then other dependencies (correctly) request v4.2.0.1 which also gets loaded. When both are loaded, a `System.MissingMethodException` is thrown! Specifically the method `ChannelReader.ReadAsync` (from `System.Threading.Tasks`) on the type `Tasks.ValueTask` (provided by `System.Threading.Tasks.Extensions`) can no longer be resolved. I do not know enough about the intricacies of method/type resolution in the full .NET Framework as to explain precisely why the presence of v4.2.0.0 causes this resolution to fail, but it certainly does. Upgrading `System.Threading.Tasks` to v6.0.0 is confirmed to solve the problem, since the newer package correctly requests `System.Threading.Tasks.Extensions` v4.2.0.1.
0d864f4 to
6c695e3
Compare
|
@david-driscoll I split the changes into three commits in case you decide to release v0.19.6 with just a backported patch, since I'm not sure how ready it is for a full release. |
|
I've also confirmed with @prpercival that the dev build I produced with the updated O# package fixed the issue on their machine too 😄 |
|
@david-driscoll the bot added the "mysterious" label and that is so freaking apt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
System.Threading.Tasksv4.7.1 is broken. Its package manifest states that it depends onSystem.Threading.Tasks.Extensions>= v4.5.4 (assembly version v4.2.0.1); however, for some reason it actually requests v4.2.0.0. While neither OmniSharp nor PowerShell Editor Services, the downstream library where this bug appeared, ship that version of the library, it can sometimes be found in the Global Assembly Cache on Windows. When present (due to an installation by some other program), it gets loaded, and then other dependencies (correctly) request v4.2.0.1 which also gets loaded. When both are loaded, aSystem.MissingMethodExceptionis thrown! Specifically the methodChannelReader.ReadAsync(fromSystem.Threading.Tasks) on the typeTasks.ValueTask(provided bySystem.Threading.Tasks.Extensions) can no longer be resolved. I do not know enough about the intricacies of method/type resolution in the full .NET Framework as to explain precisely why the presence of v4.2.0.0 causes this resolution to fail, but it certainly does. UpgradingSystem.Threading.Tasksto v6.0.0 is confirmed to solve the problem, since the newer package correctly requestsSystem.Threading.Tasks.Extensionsv4.2.0.1.I tested this and it sure seems to fix PowerShell/vscode-powershell#4175.