-
-
Notifications
You must be signed in to change notification settings - Fork 194
License compatibility #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
$param = new static(); | ||
$param->setName($reflectionParameter->getName()); | ||
|
||
if ($reflectionParameter->isArray()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about callable typehints in 5.4+ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof yes, I spawned zendframework/zendframework#4150 and zendframework/zendframework#4149 from this, but we'll need to wait for zf 2.2. I can either bump the requirement once 2.2 is out, or provide a polyfill now
@stof Didn't know about standard prefix for generated proxies ) |
@lisachenko yes, that's because proxies are not PSR-0 compliant |
@Ocramius Doctrine does not make them PSR-0 compliant either. It is not about autoloading them, but about being able to find the original class name from the proxy one when your logic needs to use the class name for something (an identifier for instance) |
@stof I have an utility for that eventually, and I moved away from the constant |
@Ocramius But it would require making the Symfony ACL system aware of your utility for instance, if you have ACLs for a class you are proxying. This was precisely one of the use case for standardizing the naming between CG and Doctrine (and refactoring Doctrine to be able to reverse-engineer the proxy class name to get the original class) |
@stof I can understand why there may be some agreement, but I don't really get the rationale behind the security component using a class name. What's the point in doing that? |
As of symfony/symfony#7527, this PR removes
jms/cg
in favour ofZend\Code
.