Added functions to print jacobian matrix in COO to matrix market #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50b60fd to
a159e3e
Compare
pelesh
previously requested changes
May 2, 2025
19f2075 to
97bc6ea
Compare
999f661 to
9c13907
Compare
|
After running For example This will generate a matrix of size |
pelesh
previously requested changes
Jun 6, 2025
…it's just for creating linear systems.
8cc1610 to
6f13f09
Compare
|
i've rebased it in the process of doing some checks. that should be sufficient |
shakedregev
commented
Jun 27, 2025
superwhiskers
approved these changes
Jun 27, 2025
WiktoriaZielinskaORNL
pushed a commit
that referenced
this pull request
Jul 23, 2025
* added the ability to print a COO matrix and a jacobian in the matrix market format * documentation * printing residual vector too * fixed recommendations * the new file actually allows you to supply N. It also removes tests, it's just for creating linear systems. * Apply pre-commmit fixes * rebase the branch and address compiler warnings * fix memory leak in the example * add iomanip include for setprecision * Apply pre-commmit fixes --------- Co-authored-by: shakedregev <shakedregev@users.noreply.github.com> Co-authored-by: superwhiskers <whiskerdev@protonmail.com> Co-authored-by: superwhiskers <superwhiskers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a new feature that enables exporting
ScaleMicrogridexamples of arbitrary size for testing.Proposed changes
The functions work as intended and the rest of the code is intact. This is a broad fix that can work for other Jacobians or COO matrices.
After running
make, in yourbuilddirectory, runFor example
This will generate a linear system with$36N-2$ variables and constraints.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
-Wall -Wpedantic -Wconversion -Wextra.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining
why you chose the solution you did and what alternatives you considered, etc...