output/http: log invalid status as a string #12128
Open
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7311 If response_status_number is not a valid poisitive integer, we should not try to parse it again, and fail again, but just log the raw string.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12128 +/- ##
===========================================
+ Coverage 62.68% 83.11% +20.43%
===========================================
Files 840 909 +69
Lines 153669 257879 +104210
===========================================
+ Hits 96323 214343 +118020
+ Misses 57346 43536 -13810
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23422 |
jasonish
reviewed
Nov 18, 2024
| @@ -2014,6 +2014,9 @@ | |||
| "status": { | |||
| "type": "integer" | |||
| }, | |||
| "status_str": { | |||
There was a problem hiding this comment.
We have no occurrences of _str, but do have one as _string, so maybe we should stick with that.
Also, please add a description. I wonder if that description should also include the rule keyword for matching? Or if not applicable, even state that somehow?
There was a problem hiding this comment.
guess a http.stat_code.raw? or http.stat.raw
There was a problem hiding this comment.
I guess I will go with status_string instead of opening a new json object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7311
Describe changes:
Also fix integer warning on the way
SV_BRANCH=OISF/suricata-verify#2085
From #11904 in its own PR