8000 [17.0] [FIX] fieldservice: FSM Person Calendar Filter by brian10048 · Pull Request #1153 · OCA/field-service · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0] [FIX] fieldservice: FSM Person Calendar Filter #1153

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[17.0] [FIX] fieldservice: FSM Person Calendar Filter #1153

merged 1 commit into from
Jan 31, 2024

Conversation

brian10048
Copy link
Contributor

forward port of #1152

Error in v17:
Screenshot from 2024-01-05 12-21-52

@brian10048 brian10048 added the bug label Jan 5, 2024
@brian10048 brian10048 added this to the 17.0 milestone Jan 5, 2024
@brian10048 brian10048 requested a review from SMaciasOSI January 5, 2024 17:22
@brian10048 brian10048 self-assigned this Jan 5, 2024
@OCA-git-bot
Copy link
Contributor

Hi @max3903,
some modules you are maintaining are being modified, check this out!

@brian10048 brian10048 mentioned this pull request Jan 5, 2024
Closed
@brian10048 brian10048 changed the title [FIX] fieldservice: FSM Person Calendar Filter [17.0] [FIX] fieldservice: FSM Person Calendar Filter Jan 5, 2024
@brian10048
Copy link
Contributor Author

after fix testing on runboat without error:

Screenshot from 2024-01-05 12-27-18

@SMaciasOSI
Copy link
Contributor

@max3903 I have tested this. It works as expected

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@brian10048
Copy link
Contributor Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1153-by-brian10048-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fe9339b into OCA:17.0 Jan 31, 2024
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f0b5475. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

@SMaciasOSI SMaciasOSI SMaciasOSI approved these changes

Assignees

@brian10048 brian10048

Labels
approved bug merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@brian10048 @OCA-git-bot @SMaciasOSI @gurneyalex
0