10000 Style, typo, and consistency fixes. · Nikki-Gu/jupyter-notify@0ac3ffc · GitHub
[go: up one dir, main page]

Skip to content

Commit

Permalink
Style, typo, and consistency fixes.
Browse files Browse the repository at this point in the history
  • Loading branch information
Stephen Brennan committed Aug 18, 2017
1 parent f807e2b commit 0ac3ffc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,12 @@ You may specify options while loading the magic:
```python
import jupyternotify
ip = get_ipython()
ip.register_magics(jupyternotify.JupyterNotifyMagics(ip,
ip.register_magics(jupyternotify.JupyterNotifyMagics(
ip,
option_name="option_value"
))
```

The following options exist:
- `require_interaction` - Boolean, default False. When this is true,
notifications will remain on screen untill dismissed.
notifications will remain on screen until dismissed.
6 changes: 3 additions & 3 deletions jupyternotify/jupyternotify.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ def __init__(self, shell, require_interaction=False):
jsString = jsFile.read()
display(Javascript(jsString))
self.options = json.dumps({
'requireInteraction': require_interaction,
'body': 'Cell Execution Has Finished!!',
'icon': '/static/base/images/favicon.ico',
"requireInteraction": require_interaction,
"body": "Cell Execution Has Finished!!",
"icon": "/static/base/images/favicon.ico",
})

@cell_magic
Expand Down

0 comments on commit 0ac3ffc

Please sign in to comment.
0