[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 页面为函数式组件时不再额外包裹 View #12305 #12339

Merged
merged 3 commits into from
Aug 22, 2022

Conversation

biorz
Copy link
Member
@biorz biorz commented Aug 21, 2022
  1. fix react-native 安卓,页面配置 disableScroll = true 时,页面高度不正确 #12305
  2. 透传 ref, 方便函数式组件配置回调 (如: componentDidShow)

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

1. fix NervJS#12305
2. 透传 ref, 方便函数式组件配置回调 (如: componentDidShow)
@biorz biorz added V-3 Version - 3.x T-rn Target - 编译到 React Native labels Aug 21, 2022
@zhiqingchen
Copy link
Member
zhiqingchen commented Aug 22, 2022

此处的目的是给每个页面设置一个默认高度。
改为不再额外包裹view,但是设置一个默认的flex:1 是否可以?

相关pr:
#9695

相关issue:
#9662

@biorz
Copy link
Member Author
biorz commented Aug 22, 2022

此处的目的是给每个页面设置一个默认高度。 改为不再额外包裹view,但是设置一个默认的flex:1 是否可以?

相关pr: #9695

相关issue: #9662

ClassComponent 类型的页面,也是没有设置高度的,此处保持一致。去除 View 后,也就不需要 flex: 1 去传递高度, 如果需要撑起,在页面中设置 flex: 1 即可。

我比较奇怪的是当时为什么要套一层 View

@zhiqingchen zhiqingchen self-requested a review August 22, 2022 11:17
@biorz biorz merged commit 5f72cb0 into NervJS:next Aug 22, 2022
@zhiqingchen
Copy link
Member
 ERROR  Warning: Function components cannot be given refs. Attempts to access this ref will fail. Did you mean to use React.forwardRef()?

Check the render method of `ForwardRef(PageComponent)`.
    in _default
    in PageComponent (created by PageScreen)
    in PageProvider (created by PageScreen)
    in RCTScrollContentView (created by ScrollView)
    in RCTScrollView (created by ScrollView)
    in ScrollView (created by ScrollView)
    in ScrollView (created by PageScreen)
    in PageScreen (created by SceneView)
    in StaticContainer
    in EnsureSingleNavigator (created by SceneView)
    in SceneView (created by BottomTabView)
    in RCTView (created by View)
    in View (created by Screen)
    in RCTView (created by View)
    in View (created by Background)
    in Background (created by Screen)
    in Screen (created by BottomTabView)
    in RNSScreen (created by AnimatedComponent)
    in AnimatedComponent
    in Unknown (created by Screen)
    in MaybeFreeze (created by Screen)
    in Screen (created by MaybeScreen)
    in MaybeScreen (created by BottomTabView)
    in RNSScreenNavigationContainer (created by ScreenContainer)
    in ScreenContainer (created by MaybeScreenContainer)
    in MaybeScreenContainer (created by BottomTabView)
    in RCTView (created by View)
    in View (created by SafeAreaInsetsContext)
    in SafeAreaProviderCompat (created by BottomTabView)
    in BottomTabView (created by BottomTabNavigator)
    in Unknown (created by BottomTabNavigator)
    in BottomTabNavigator (created by SceneView)
    in StaticContainer
    in EnsureSingleNavigator (created by SceneView)
    in SceneView (created by SceneView)
    in RCTView (created by View)
    in View (created by DebugContainer)
    in DebugContainer (created by MaybeNestedStack)
    in MaybeNestedStack (created by SceneView)
    in RNSScreen (created by AnimatedComponent)
    in AnimatedComponent
    in Unknown (created by Screen)
    in MaybeFreeze (created by Screen)
    in Screen (created by SceneView)
    in SceneView (created by NativeStackViewInner)
    in RNSScreenStack (created by ScreenStack)
    in ScreenStack (created by NativeStackViewInner)
    in NativeStackViewInner (created by NativeStackView)
    in RNCSafeAreaProvider (created by SafeAreaProvider)
    in SafeAreaProvider (created by SafeAreaInsetsContext)
    in SafeAreaProviderCompat (created by NativeStackView)
    in NativeStackView (created by NativeStackNavigator)
    in Unknown (created by NativeStackNavigator)
    in NativeStackNavigator (created by Entry)
    in EnsureSingleNavigator
    in Unknown
    in ThemeProvider
    in NavigationContainerInner (created by Entry)
    in App (created by Entry)
    in RCTView (created by View)
    in View (created by Portal.Host)
    in Portal.Host (created by Provider)
    in ThemeProvider (created by Provider)
    in LocaleProvider (created by Provider)
    in Provider (created by Entry)
    in ChildrenWrapper (created by Root)
    in _default (created by Root)
    in Root (created by RootSiblingParent)
    in RootSiblingParent (created by Entry)
    in Entry
    in RCTView (created by View)
    in View (created by AppContainer)
    in ChildrenWrapper (created by Root)
    in _default (created by Root)
    in Root (created by AppContainer)
    in RCTView (created by View)
    in View (created by AppContainer)
    in AppContainer
    in taroDemo(RootComponent)
 BUNDLE  ./index

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rn Target - 编译到 React Native V-3 Version - 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native 安卓,页面配置 disableScroll = true 时,页面高度不正确
2 participants