fix(router): routing services should be provided in forRoot only#1729
Merged
fix(router): routing services should be provided in forRoot only#1729
Conversation
0b64fd5 to
d76e04a
Compare
ADjenkov
approved these changes
Feb 19, 2019
dottodot
pushed a commit
to dottodot/nativescript-angular
that referenced
this pull request
Mar 16, 2019
* master: exclude files from api ref build NS Angular api ref build script fix(location-strategy): crash on going back with router-outlet after closing modal (NativeScript#1748) release: cut the 7.2.2 release (NativeScript#1742) fix(router): routing services should be provided in forRoot only (NativeScript#1729) fix(list-view): Add support for default item template fix(list-view): add support for "defailtTemplate" docs: cut the 7.2.1 release fix: Router tracing does not work with webpack chore: bump package version to 7.2.1 chore: bump package versino tp 7.3.0 test: Add tests for nested primary outlets fix(location-strategy): extend support for nested primary outlets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There are a couple of flaws in the
NativeScriptRouterModule:LocationStrategy,RouteReuseStrategy,RouterExtensions, etc.) are provided inside theNativeScriptRouterModulemodule. This might cause issues with lazy loaded modules which importNativeScriptRouterModule.forRoot()andforChild()methods ofNativeScriptRouterModuledo not export the actualNativeScriptRouterModule(only the stockRouterModuleform angular). This means that you will have to import bothNativeScriptRouterModule.forRoot/forChild(routes)andNativeScriptRouterModulein every module.What is the new behavior?
NativeScriptRouterModule.forRoot(), similar to [AngularRouterModule`](https://github.com/angular/angular/blob/master/packages/router/src/router_module.ts#L133-L199)forRoot()andforChild()now export the actualNativeScriptRouterModule. Now it should required to importNativeScriptRouterModuleif you haveforChild()orforRoot()Warning
The
forRootandfotChildmethods should contain a single return statement (source). Failing to comply with that leads to the following weird error when building projects with AOT:Function calls are not supported in decorators but 'NativeScriptRouterModule' was called.