fix(dialogs): properly handle shared modal when using TabView as a root#1610
Merged
fix(dialogs): properly handle shared modal when using TabView as a root#1610
Conversation
…ipt/nativescript-angular into djenkov/modal-root-tab
… path to Outlet when search in the UrlTree for the given Outlet
ed5e9ba to
0e9a6ae
Compare
MartoYankov
approved these changes
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer Note 1: If showing a modal view early in the app workflow (imagine showing modal inside
ngOnInitof app.component.ts e.g) there won't beFramefrom whom to initiate the ModalView appearance. It is possible that there is even notopmost()frame at that very moment. We shouldn't treat such Modals as a regular Modal views, initiated by some user action later in the app, but as regular page navigations.Developer Note 2: We should set
currentOutletto the Outlet that corresponds thetopmost()Frame when closing ModalView and there is no previous Outlet that hadshowingModal=trueproperty set (the scenario from Developer Note 1 e.g.)Developer Note 3: Introduce path property to Outlet (holds the url path to this outlet). Match thе path to Outlet when search in the UrlTree for the given Outlet (
getSegmentGroupByOutlet()method).