8000 feat: allow providing custom dialog view by edusperoni · Pull Request #126 · NativeScript/angular · GitHub
[go: up one dir, main page]
Skip to content

feat: allow providing custom dialog view #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat: allow providing custom dialog view #126

merged 1 commit into from
Jul 17, 2024

Conversation

edusperoni
Copy link
Collaborator

Allows providing a custom dialog view to render the dialog. Useful when you want to pass the viewcontainerref but don't want the dialog to be constructed in that place

@cla-bot cla-bot bot added the cla: yes label Nov 30, 2023
@NathanWalker NathanWalker merged commit 16bfffb into main Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edusperoni @NathanWalker
0