8000 fix(ios): Do not call setNeedsLayout() when another layout update request is in process by CatchABus · Pull Request #9875 · NativeScript/NativeScript · GitHub
[go: up one dir, main page]
Skip to content

fix(ios): Do not call setNeedsLayout() when another layout update request is in process #9875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(ios): Do not call setNeedsLayout() when another layout update request is in process #9875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4803d61
fix(ios): Do not call `requestLayout()` when another layout update is…
CatchABus Apr 15, 2022
35ebb5f
fix: Do not prevent call of super class method as it may cause layout…
CatchABus Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/core/ui/core/view/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ export class View extends ViewCommon implements ViewDefinition {

public requestLayout(): void {
super.requestLayout();

// Do not call 'setNeedsLayout' for views that have already requested a layout update
if (this.isLayoutRequested) {
return;
}

this._privateFlags |= PFLAG_FORCE_LAYOUT;

const nativeView = this.nativeViewProtected;
Expand Down
0