8000 fix(webpack5): Remove 'ts-loader' from webpack 'javascript' configuration by CatchABus · Pull Request #9715 · NativeScript/NativeScript · GitHub
[go: up one dir, main page]
Skip to content

fix(webpack5): Remove 'ts-loader' from webpack 'javascript' configuration #9715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

fix(webpack5): Remove 'ts-loader' from webpack 'javascript' configuration #9715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
87fc0bf
fix: Exclude typescript definition files from `ts-loader` since they …
CatchABus Dec 25, 2021
6a16dfe
chore: Added comment so that developers know why this rule is there.
CatchABus Dec 25, 2021
d8f63d0
test: Corrected test snapshots related to `ts-loader`.
CatchABus Dec 25, 2021
383a852
fix: Corrected regex escape in test snapshot.
CatchABus Dec 25, 2021
a42d52d
chore: Reverting webpack changes.
CatchABus Dec 25, 2021
21e9af0
chore: Removed leftovers.
CatchABus Dec 25, 2021
f156c9e
fix: Proper way to disable `ts-loader` for javascript configuration.
CatchABus Dec 25, 2021
a203899
test: Removed `ts-loader` references from javascript configuration sn…
CatchABus Dec 25, 2021
897c66e
chore: Put `config` removals at the beginning of procedure.
CatchABus Dec 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions packages/webpack5/__tests__/configuration/__snapshots__/javascript.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,27 +85,6 @@ exports[`javascript configuration for android 1`] = `
}
]
},
/* config.module.rule('ts') */
{
test: [
/\\\\.ts$/
],
use: [
/* config.module.rule('ts').use('ts-loader') */
{
loader: 'ts-loader',
options: {
transpileOnly: true,
allowTsInNodeModules: true,
compilerOptions: {
sourceMap: true,
declaration: false
},
getCustomTransformers: function () { /* omitted long function */ }
}
}
]
},
/* config.module.rule('js') */
{
test: /\\\\.js$/,
Expand Down Expand Up @@ -408,27 +387,6 @@ exports[`javascript configuration for ios 1`] = `
}
]
},
/* config.module.rule('ts') */
{
test: [
/\\\\.ts$/
],
use: [
/* config.module.rule('ts').use('ts-loader') */
{
loader: 'ts-loader',
options: {
transpileOnly: true,
allowTsInNodeModules: true,
compilerOptions: {
sourceMap: true,
declaration: false
},
getCustomTransformers: function () { /* omitted long function */ }
}
}
]
},
/* config.module.rule('js') */
{
test: /\\\\.js$/,
Expand Down
3 changes: 3 additions & 0 deletions packages/webpack5/src/configuration/javascript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ export default function (config: Config, env: IWebpackEnv = _env): Config {
// VIRTUAL ENTRY END
`
);

// remove default ts rule
config.module.rules.delete('ts');

// exclude files starting with _ from require.context
config
Expand Down
0