8000 fix(webpack): exclude other platforms from require.context by rigor789 · Pull Request #9686 · NativeScript/NativeScript · GitHub
[go: up one dir, main page]
Skip to content

fix(webpack): exclude other platforms from require.context #9686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 18, 2022
Merged

fix(webpack): exclude other platforms from require.context #9686

merged 5 commits into from
Feb 18, 2022

Conversation

rigor789
Copy link
Member

PR Checklist

What is the current behavior?

require.context may include .android.ts etc files when building for ios, and the other way around.

What is the new behavior?

require.context should not include other platforms code.

fixes #9682

@cla-bot cla-bot bot added the cla: yes label Nov 30, 2021
@rigor789 rigor789 added this to the 8.2 milestone Dec 14, 2021
@rigor789 rigor789 self-assigned this Dec 14, 2021
@rigor789 rigor789 merged commit cb7bd2a into master Feb 18, 2022
@rigor789 rigor789 deleted the fix/webpack-require-context-other-platforms branch February 18, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rigor789 rigor789

Labels
cla: yes webpack
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.

[Webpack5] Other platform code wrongfully included in bundle
2 participants
@rigor789 @NathanWalker
0