8000 chore(webpack5): update react-refresh by wSedlacek · Pull Request #9675 · NativeScript/NativeScript · GitHub
[go: up one dir, main page]
Skip to content

chore(webpack5): update react-refresh #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2021
Merged

chore(webpack5): update react-refresh #9675

merged 1 commit into from
Nov 21, 2021

Conversation

wSedlacek
Copy link
Contributor

PR Checklist

What is the current behavior?

When installing @nativescript/webpack@5 the following warnings are shown

npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.

What is the new behavior?

The deprecated packages have been updated so no warnings are shown.

@cla-bot cla-bot bot added the cla: yes label Nov 20, 2021
@wSedlacek
Copy link
Contributor Author

Tested with fresh project

Screen.Recording.2021-11-21.at.07.43.27.mov

@wSedlacek wSedlacek marked this pull request as ready for review November 21, 2021 16:43
@rigor789 rigor789 merged commit bbd2aa9 into NativeScript:master Nov 21, 2021
@wSedlacek wSedlacek deleted the chore/update-react-refresh branch November 21, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 rigor789 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wSedlacek @rigor789
0