8000 fix: refactor background handling. by farfromrefug · Pull Request #9223 · NativeScript/NativeScript · GitHub
[go: up one dir, main page]
Skip to content

fix: refactor background handling. #9223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

fix: refactor background handling. #9223

wants to merge 11 commits into from

Conversation

farfromrefug
Copy link
Collaborator

The idea is for views to handle special case themselves.
I realised that android.widget.Button was materialized even if you were not using it because there was a test for instanceof in the background handling. Now the special background handling is done in Button and ActionBar

Also we dont create the _cachedDrawable again. Instead we use the one we got from backgroundInternal.getDefault.

It also makes the code much easier to understand.

@farfromrefug
fix: refactor background handling.
5fc7d1a 
The idea is for views to handle sepecial case themselves.
I realised that android.widget.Button was materialized even if you were not using it because there was a test for instanceof in the background handling. Now the special background handling is done in Button and ActionBar
@farfromrefug
fix: automated tests are now passing
016313b
@farfromrefug
fix: removed duplicated line
f7e9c6b
@cla-bot cla-bot bot added the cla: yes label Feb 17, 2021
@farfromrefug farfromrefug mentioned this pull request Mar 12, 2021
Closed
@NathanWalker NathanWalker added this to the 8.1 milestone Apr 2, 2021
NathanWalker
NathanWalker previously approved these changes Apr 2, 2021
View reviewed changes
@rigor789
Copy link
Member
rigor789 commented Apr 3, 2021

@NathanWalker we actually can't merge this with the 8.0 changes, will need to redo on top of the 8.0 changes.

@rigor789 rigor789 marked this pull request as draft April 3, 2021 00:07
@NathanWalker NathanWalker marked this pull request as ready for review April 6, 2021 23:34
@farfromrefug
Copy link
Collaborator Author

@rigor789 i think i merged it with 8.0.0 and boxShadows. All tests are passing. Should also fix the issue with actionbar background color

rigor789
rigor789 reviewed Apr 9, 2021
View reviewed changes
farfromrefug and others added 3 commits April 9, 2021 10:37
@farfromrefug @rigor789
Update packages/core/ui/core/view/index.android.ts
196b091 
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
@farfromrefug @rigor789
Update packages/core/ui/action-bar/index.android.ts
ffe150c 
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
@farfromrefug
chore: remove empty namespace
0e416d8
@farfromrefug
Copy link
Collaborator Author

@rigor789 could we merge this in 8.1.0 ? i confirmed it fixes this issue (it works in my fork) #9263

@farfromrefug farfromrefug mentioned this pull request Sep 1, 2021
Merged
5 tasks
@rigor789 rigor789 changed the base branch from master to release/8.1.0 September 1, 2021 16:34
@rigor789 rigor789 deleted the branch NativeScript:release/8.1.0 September 10, 2021 17:52
@rigor789 rigor789 closed this Sep 10, 2021
@farfromrefug farfromrefug mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789 rigor789 approved these changes

@NathanWalker NathanWalker NathanWalker left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@farfromrefug @rigor789 @NathanWalker
0