fix: refactor background handling. #9223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is for views to handle sepecial case themselves. I realised that android.widget.Button was materialized even if you were not using it because there was a test for instanceof in the background handling. Now the special background handling is done in Button and ActionBar
NathanWalker
previously approved these changes
Apr 2, 2021
|
@NathanWalker we actually can't merge this with the 8.0 changes, will need to redo on top of the 8.0 changes. |
|
@rigor789 i think i merged it with 8.0.0 and boxShadows. All tests are passing. Should also fix the issue with actionbar background color |
rigor789
reviewed
Apr 9, 2021
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
rigor789
approved these changes
Apr 9, 2021
5 tasks
583d84a to
a5b1a18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is for views to handle special case themselves.
I realised that android.widget.Button was materialized even if you were not using it because there was a test for instanceof in the background handling. Now the special background handling is done in Button and ActionBar
Also we dont create the
_cachedDrawableagain. Instead we use the one we got frombackgroundInternal.getDefault.It also makes the code much easier to understand.