Closed
Description
I'm trying to test a contribution to the v6 tns-core-modules and tns-core-modules-widgets, and running into problems following the DevelopmentWorkflow.md. I think it is outdated.
In short, I want to modify a .ts file in tns-core-modules and be able to test the modification in a v6 NativeScript app in another directory.
A few issues with the current DevelopmentWorkflow.md:
- The initial setup (
npm install) does not npm link - Running Another App indicates changes require TS rebuild (tsc), however it does not specify which package.json
scripttarget to run. My hunch is it isdev-tsc-allbut this script has a bug in it (pr below) AND after running, the.jsfiles end up inbin/dist/tns-core-modules/without apackage.json(sonpm linkwill not work).compile-allscript does the same. dev-link-tns-core-modules-widgetsscript references adist/packagedir that DNE.
I'm happy to do the work to PR an update to the docs, however I need some clarity on the right way to do it 1st.
Here is my workflow - what am I doing wrong?
- Fork and clone
git checkout -b my-feature/fix-branchnpm installnpm run compile-all- From root of my NS proj:
npm link ../<where I cloned>/tns-core-modules-widgets/ && npm link ../<where I cloned>/tns-core-modules tns debug ios --debug-brk --env.sourceMap