8000 Navigations by SRWieZ · Pull Request #46 · NativePHP/nativephp.com · GitHub
[go: up one dir, main page]
Skip to content

Navigations #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 15, 2024
Merged

Navigations #46

merged 10 commits into from
Sep 15, 2024

Conversation

SRWieZ
Copy link
Member
@SRWieZ SRWieZ commented Sep 14, 2024 •
edited
Loading

List of modifications

  • sticky header navigation
  • highlight current on right side navigation
  • Show ToC persistently on the right-hand side
  • Add pinkary / Linkedin / open collective icons
  • Check dark mode
  • Mobile menu
  • Add a copy button to torchlight

@SRWieZ SRWieZ mentioned this pull request Sep 14, 2024
Open
24 tasks
@simonhamp
Copy link
Member

Can you add some screenshots to the PR? I'm out at the moment so I can't run this branch

@SRWieZ
Copy link
Member Author
SRWieZ commented Sep 14, 2024

Done for the day 😉

A before => After

Capture d’écran 2024-09-14 à 17 53 23 Capture d’écran 2024-09-14 à 17 53 28

@SRWieZ
Copy link
Member Author
SRWieZ commented Sep 15, 2024

Darkmode

Capture d’écran 2024-09-15 à 17 01 43 Capture d’écran 2024-09-15 à 17 01 46

Darkmode mobile

Capture d’écran 2024-09-15 à 17 02 02 Capture d’écran 2024-09-15 à 17 02 06

Mobile menu

Capture d’écran 2024-09-15 à 17 02 19 Capture d’écran 2024-09-15 à 17 02 21

@SRWieZ
Copy link
Member Author
SRWieZ commented Sep 15, 2024

It's ready for review @simonhamp!

I'm sorry for the scope of this PR. It was meant to stay on the navigation side, but when I started working on the ToC, I needed to change the layout and other things. After that, it did get out of hand; I added a copy button on the code block and rewrote the responsive menu.

The best way to review is to check out this branch and look side by side with the production version.

I tried to keep things mostly in the same place.

I did a self-review today, and I think it's ready to be merged as it is.

I can make changes in other PR if needed. In future PRs, I would like to:

  • Uniformize Events documentation; it's different on each page (MenuBar, PowerMonitor, Windows)
  • Rename some things (why is the header nav called banner? 😄)
  • Extract some components maybe (logo list)

@simonhamp simonhamp changed the title [WIP] Navigations Navigations Sep 15, 2024
@simonhamp
Copy link
Member

This is really great! Thanks so much 🙏🏼

@simonhamp simonhamp merged commit 8db2d0f into NativePHP:main Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhamp simonhamp simonhamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SRWieZ @simonhamp
0