8000 Docs for Screen facade by SRWieZ · Pull Request #45 · NativePHP/nativephp.com · GitHub
[go: up one dir, main page]

Skip to content

Docs for Screen facade #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2024
Merged

Docs for Screen facade #45

merged 5 commits into from
Sep 15, 2024

Conversation

SRWieZ
Copy link
Member
@SRWieZ SRWieZ commented Sep 14, 2024

Base documentation for Screens

I took the part not to repeat the use statement in each example.

Note: In the first release of NativePHP, I experimented with Screens and wrote some helper functions, like the one I included in the documentation. While digging to write this page, I found some handy functions that do the same thing in Electron. Should we implement all those functions?

@SRWieZ SRWieZ mentioned this pull request Sep 14, 2024
24 tasks
@simonhamp
Copy link
Member

Thanks for this @SRWieZ

Should we implement all those functions?

Feel free to create a PR to cover any that you want and would use. I don't want to overthink it, and we definitely shouldn't try to cover the whole Electron API - it will come as needed.

SRWieZ and others added 3 commits September 14, 2024 16:02
Co-authored-by: Simon Hamp <simon.hamp@me.com>
Co-authored-by: Simon Hamp <simon.hamp@me.com>
@SRWieZ
Copy link
Member Author
SRWieZ commented Sep 15, 2024

Next week, I will try to make a PR to NativePHP for my helpers and also the 3 events that I think are useful.

This one is ready to merge.

@simonhamp simonhamp merged commit 42f23d2 into NativePHP:main Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0