8000 Menu improvements by simonhamp · Pull Request #423 · NativePHP/laravel · GitHub
[go: up one dir, main page]
Skip to content

Menu improvements #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 1, 2024
Merged

Menu improvements #423

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a3a8936
Extract MenuBuilder
simonhamp Nov 20, 2024
bff79d7
Add more Electron MenuItem roles
simonhamp Nov 20, 2024
9d407ce
Allow MenuItems to have submenus
simonhamp Nov 20, 2024
97bc40b
enabled/disabled
simonhamp Nov 20, 2024
0e2429f
Add GoToUrl convenience item
simonhamp Nov 20, 2024
428819b
Fix styling
simonhamp Nov 20, 2024
e066697
Add help and hide roles
simonhamp Nov 20, 2024
4ad23a6
Receive combo key data
simonhamp Nov 20, 2024
c1874ee
Add id's to menu items
simonhamp Nov 20, 2024
37f0040
Support radio items
simonhamp Nov 20, 2024
23c3363
Style
simonhamp Nov 20, 2024
7c1cca5
Remove custom event menu item type
simonhamp Nov 20, 2024
f857938
Support custom event firing on all menu items
simonhamp Nov 20, 2024
1c8931e
Fix label
simonhamp Nov 20, 2024
c6cc7e0
Type hints and consistency
simonhamp Nov 20, 2024
a180a16
Fix styling
simonhamp Nov 20, 2024
a6a6f30
Get rid of the yucky GoTo* stuff
simonhamp Nov 20, 2024
3825635
Fix test
simonhamp Nov 20, 2024
2f4d01f
Add hotkey alias method
simonhamp Dec 1, 2024
2afe2e4
Update docblock
simonhamp Dec 1, 2024
9fe62d4
Make Menu JsonSerializable
simonhamp Dec 1, 2024
d19389e
Fix styling
simonhamp Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Receive combo key data
  • Loading branch information
@simonhamp
simonhamp committed Nov 20, 2024
commit 4ad23a6df938a9ed10c26b66aaeca2be905fb268
2 changes: 1 addition & 1 deletion src/Events/Menu/MenuItemClicked.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class MenuItemClicked implements ShouldBroadcastNow
{
use Dispatchable, InteractsWithSockets, SerializesModels;

public function __construct(public array $item) {}
public function __construct(public array $item, public array $combo = []) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some PHP Doc here to represent:

array:2 [▼
  "item" => array:2 [▼
    "label" => "Settings"
    "checked" => false
  ]
  "combo" => array:5 [▼
    "shiftKey" => false
    "ctrlKey" => false
    "altKey" => false
    "metaKey" => false
    "triggeredByAccelerator" => false
  ]
]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes straight from Electron and I don't want the docblock structure to be wrong if/when they change things, as that would be more confusing imo. Perhaps at some point we create our own abstraction around this? 🤷🏻‍♂️


public function broadcastOn()
{
Expand Down
0