8000 Pre & Post Build Command Support by PeteBishwhip · Pull Request #167 · NativePHP/electron · GitHub
[go: up one dir, main page]
Skip to content

Pre & Post Build Command Support #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 22, 2025
Merged

Pre & Post Build Command Support #167

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c2b4f4d
Implement Pre and Post Processing
Feb 18, 2025
80277dc
Provide pre and post-process functionality to build command
Feb 18, 2025
1dd1314
Refactor to align with change to config keys
Feb 18, 2025
05121d2
Test
Feb 18, 2025
1be0d77
Fix styling
PeteBishwhip Feb 18, 2025
4fda3f8
Rmeove changes to yarn.lock
Feb 18, 2025
ec176cd
Remove no-longer necessary keys
Feb 18, 2025
66af0b0
Allow dynamic properties on mock class
Feb 18, 2025
391fef3
Reduce complexity, remove Mockery, update test
Feb 21, 2025
8ad121a
Fix styling
PeteBishwhip Feb 21, 2025
dd0ebdd
Merge branch 'main' into feature/493-second-pass-pre-post-build-config
SRWieZ Feb 21, 2025
4d3af32
Fix styling
SRWieZ Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove no-longer necessary keys
  • Loading branch information
Pete Bishop committed Feb 18, 2025
commit ec176cdd4660581d2e554b9de79cbffb8566bfef
4 changes: 2 additions & 2 deletions src/Commands/BuildCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function handle(): void
{
$this->info('Build NativePHP app…');

$this->preProcess('build');
$this->preProcess();

Process::path(__DIR__.'/../../resources/js/')
->env($this->getEnvironmentVariables())
Expand Down Expand Up @@ -69,7 +69,7 @@ public function handle(): void
echo $output;
});

$this->postProcess('build');
$this->postProcess();
}

protected function getEnvironmentVariables(): array
Expand Down
Loading
0