Use tuning policy as tag for tuning environment#7835
Open
bernhardmgruber wants to merge 5 commits intoNVIDIA:mainfrom
Open
Use tuning policy as tag for tuning environment#7835bernhardmgruber wants to merge 5 commits intoNVIDIA:mainfrom
bernhardmgruber wants to merge 5 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
4b91b7f to
9f03fbc
Compare
miscco
reviewed
Mar 2, 2026
5f8bac3 to
57f66ab
Compare
57f66ab to
692dd1e
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
a96dc98 to
7b0534b
Compare
1 task
Contributor
😬 CI Workflow Results🟥 Finished in 2h 15m: Pass: 63%/298 | Total: 8d 13h | Max: 2h 14m | Hits: 78%/170031See results here. |
miscco
reviewed
Mar 10, 2026
Contributor
There was a problem hiding this comment.
I repeat, this looks soo much better
<
8000
div class="blob-wrapper border-bottom js-check-hidden-unicode">
|
|
||
| return detail::rfa::dispatch<InputIteratorT, OutputIteratorT, offset_t, T, TransformOpT, accum_t, policy_t>( | ||
| d_temp_storage, temp_storage_bytes, d_in, d_out, static_cast<offset_t>(num_items), init, stream, transform_op); | ||
| return detail::rfa::dispatch<InputIteratorT, OutputIteratorT, offset_t, T, TransformOpT, accum_t>( |
Contributor
There was a problem hiding this comment.
Question: Do we actually need the explicit template arguments beyond accum_t?
Suggested change
| return detail::rfa::dispatch<InputIteratorT, OutputIteratorT, offset_t, T, TransformOpT, accum_t>( | |
| return detail::rfa::dispatch<accum_t>( |
Contributor
Author
There was a problem hiding this comment.
I need to verify this case by case. There are some algorithms that want to override the accumulator that the dispatch function deduces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detail::transform::dispatch#7810DeviceScan#7565 (so we can migrate env unit tests using scan policies)This proposes a simplification of how users can define their tunings.