Move delay constructor policies somewhere central#7530
Closed
bernhardmgruber wants to merge 2 commits intoNVIDIA:mainfrom
Closed
Move delay constructor policies somewhere central#7530bernhardmgruber wants to merge 2 commits intoNVIDIA:mainfrom
bernhardmgruber wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Contributor
Author
|
@griwes this probably affects you for the scan rewrite as well! |
Contributor
😬 CI Workflow Results🟥 Finished in 6h 01m: Pass: 93%/110 | Total: 4d 17h | Max: 6h 01m | Hits: 81%/108404See results here. |
Contributor
Aye, I have an almost identical patch set in my working branch, except with a separate header. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are going to reuse them for a bunch of CUB algorithms, this PR extracts some delay constructor policies and stuff and moves it to a more central header.
Let me know if the new place is good. I also considered
tuning/common.cuh.