8000 MicrosoftConsoleJsonLayout - Skip Encode for Timestamp and LogLevel by snakefoot · Pull Request #776 · NLog/NLog.Extensions.Logging · GitHub
[go: up one dir, main page]

Skip to content

MicrosoftConsoleJsonLayout - Skip Encode for Timestamp and LogLevel #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

snakefoot
Copy link
Contributor
@snakefoot snakefoot commented Nov 24, 2024

Skip verification of characters that must be json-encoded for TimeStamp and LogLevel for better performance.

@snakefoot snakefoot enabled auto-merge (squash) November 24, 2024 18:53
@snakefoot snakefoot closed this Nov 28, 2024
auto-merge was automatically disabled November 28, 2024 18:59

Pull request was closed

@snakefoot snakefoot reopened this Nov 28, 2024
@snakefoot snakefoot enabled auto-merge (squash) November 28, 2024 19:01
@snakefoot snakefoot changed the title MicrosoftConsoleJsonLayout - Unit Test TimestampFormat MicrosoftConsoleJsonLayout - Skip Encode for Timestamp and LogLevel Nov 28, 2024
@snakefoot snakefoot merged commit 699e3ab into NLog:master Nov 28, 2024
3 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.55%. Comparing base (b28d631) to head (cc6b983).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ions.Logging/Layouts/MicrosoftConsoleJsonLayout.cs 58.33% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #776      +/-   ##
==========================================
+ Coverage   81.01%   81.55%   +0.54%     
==========================================
  Files          19       19              
  Lines        1817     1762      -55     
  Branches      320      315       -5     
==========================================
- Hits         1472     1437      -35     
+ Misses        198      182      -16     
+ Partials      147      143       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0