Ditch PurgeCSS, configure uswds to use only tablet #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dzole0311
approved these changes
Aug 20, 2024
hanbyul-here
added a commit
to US-GHG-Center/veda-config-ghg
that referenced
this pull request
Aug 22, 2024
Close NASA-IMPACT/veda-ui#1098 I used this PR as a test-bed to figure out how to write a component using USWDS design system. The rules that I tried to stick is like below. 1. Use uswds-react whenever possible. 2. Use USWDS helper, utility className whenever possible. 3. Use Styled components for prop-based dynamic styling. 4. Use classnames for static custom styles 🤔 I think, as a team, we only agreed on 1. altogether. (And I expressed my bias towards 2.) - other steps came to be kind of natural, but this might not be the case for everybody. So let's discuss if anything doesn't look right! @faustoperez - I made the whole (- link area) card to be clickable This PR NASA-IMPACT/veda-ui#1112 needs to be merged first @slesaad - 🤔 I am not sure what to do with ui module because this change does require the update of UI module. Should I let this PR sit until the next release?
sandrahoang686
added a commit
that referenced
this pull request
Aug 27, 2024
## 🎉 Features - 🦗 ## 🚀 Improvements - Adding styles & Configurations for R3 #1104 - Create new raster paint layer module and factor out BaseTimeseriesProps #1105 - Remove PurgeCSS, configure USWDS to use only tablet breakpoints #1112 - Open an external link in a new tab #1116 - Expose USWDS card style #1119 ## 🐛 Fixes - Do not render exploration component unless urlAtom is on the right page #1106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes