8000 Disentangle the unit tests for `Color` and `Value` · Issue #1057 · MyIntervals/PHP-CSS-Parser · GitHub
[go: up one dir, main page]
Skip to content

Disentangle the unit tests for Color and Value #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oliverklee opened this issue Mar 3, 2025 · 0 comments
Open

Disentangle the unit tests for Color and Value #1057

oliverklee opened this issue Mar 3, 2025 · 0 comments
Assignees
@oliverklee
Labels
cleanup
Milestone
9.0.0: Drop suppo...

Comments

@oliverklee
Copy link
Contributor

Currently, the tests test both parsing as well as rendering (in the same test).

We should disentangle this:

  • parsing tests (unit or functional)
  • rendering tests (functional)

This currently also kind of blocks the removal of __toString().
@oliverklee oliverklee mentioned this issue Mar 3, 2025
Closed
@oliverklee oliverklee self-assigned this Mar 4, 2025
oliverklee added a commit that referenced this issue Mar 5, 2025
@oliverklee
[TASK] Extract value parsing functional tests (part 1)
135725e 
In the tests, we should test parsing and rendering separately
as this makes debugging test failures a lot easier.

Part of #1057
@oliverklee oliverklee mentioned this issue Mar 5, 2025
Merged
JakeQZ pushed a commit that referenced this issue Mar 5, 2025
@oliverklee
[TASK] Extract value parsing functional tests (part 1) (#1084)
2c3fe72 
In the tests, we should test parsing and rendering separately
as this makes debugging test failures a lot easier.

Part of #1057
oliverklee added a commit that referenced this issue Mar 16, 2025
@oliverklee
[TASK] Avoid the deprecated __toString() in tests
0680620 
Moving some tests to functional tests and splitting them up
will come in later changes for #1057.
@oliverklee oliverklee mentioned this issue Mar 16, 2025
Merged
JakeQZ pushed a commit that referenced this issue Mar 16, 2025
@oliverklee
[TASK] Avoid the deprecated __toString() in tests (#1180)
f9609c4 
Moving some tests to functional tests and splitting them up
will come in later changes for #1057.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

No branches or pull requests
1 participant
@oliverklee
0