8000 Add 9-sliced background to chat by luk3yx · Pull Request #194 · MultiCraft/MultiCraft · GitHub
[go: up one dir, main page]
Skip to content

Add 9-sliced background to chat #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
luk3yx wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add 9-sliced background to chat #194

luk3yx wants to merge 4 commits into from

Conversation

@luk3yx
Copy link
Member
@luk3yx luk3yx commented Jun 27, 2024

Add compact, short information about your PR for easier understanding:

  • Goal of the PR
  • How does the PR work?
  • Does it resolve any reported issue?
  • If not a bug fix, why is this PR needed? What usecases does it solve?

To do

This PR is a Work in Progress / Ready for Review.

  • List
  • Things
  • To do

How to test

@MoNTE48
Copy link
Member
MoNTE48 commented Jun 27, 2024

Can you add screenshot how it looks when bg_common.png is used?

@luk3yx
Copy link
Member Author
luk3yx commented Jun 27, 2024

image

@MoNTE48
Copy link
Member
MoNTE48 commented Jun 27, 2024 •
edited
Loading

Hmm, I think the console should be a little longer so as not to cut off the scrollbar.

MoNTE48
MoNTE48 reviewed Jun 28, 2024
View reviewed changes
src/gui/guiChatConsole.cpp Outdated
driver,
m_background,
core::rect<s32>(0, 0, m_screensize.X, m_height),
core::rect<s32>(0, 0, m_screensize.X, m_height + 16),
Copy link
Member
@MoNTE48 MoNTE48 Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it just made it worse and cropped the background.

luk3yx and others added 2 commits June 30, 2024 20:28
@luk3yx
Improve chat console look
555b1da 
The comment is worded badly because I am tired, sorry.
@MoNTE48
Add background image
a3e9112
@MoNTE48 MoNTE48 force-pushed the main branch 6 times, most recently from 1f0f82b to 5b99b2a Compare January 15, 2025 19:29
@MoNTE48 MoNTE48 force-pushed the main branch 3 times, most recently from 444870b to 0440189 Compare April 7, 2025 12:11
@MoNTE48 MoNTE48 force-pushed the main branch 2 times, most recently from 90b9169 to 7134498 Compare August 18, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoNTE48 MoNTE48 MoNTE48 left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luk3yx @MoNTE48
0