feat(lessons): add dynamic experience memory system #723
Conversation
- Add lessons module with LLM-judged extraction from agent trajectories - Support automatic lesson creation, updating, and retirement - Implement score-based eviction (frequency × freshness × effectiveness × quality) - Add dynamic skill discovery at each step for immediate lesson availability - Store lessons in project directory (.kimi/skills > .agent/skills > .claude/skills) - Add comprehensive debug logging for lesson system tracing
| return path, True | ||
|
|
||
| # Maximum number of lessons to keep | ||
| MAX_LESSONS = 20 |
There was a problem hiding this comment.
🟡 Config value max_lessons_per_scope is ignored - hardcoded MAX_LESSONS=20 is used instead
The LessonsConfig.max_lessons_per_scope configuration value (default 50) is defined but never used. The LessonManager class uses a hardcoded MAX_LESSONS = 20 constant instead.
Click to expand
How the bug manifests
Users can configure max_lessons_per_scope in their config expecting it to control the lesson limit:
[lessons]
max_lessons_per_scope = 100However, the LessonManager at src/kimi_cli/lessons/manager.py:504 uses a hardcoded value:
MAX_LESSONS = 20This constant is used in:
evict()method at line 522:max_count = self.MAX_LESSONSshould_evict()method at line 585:return self.get_lesson_count() >= self.MAX_LESSONS
The config value at src/kimi_cli/config.py:130-133 is never referenced anywhere in the codebase.
Impact
Users who configure max_lessons_per_scope will have their setting silently ignored. The system will always evict lessons when count reaches 20, regardless of the configured value of 50 (default) or any custom value.
Recommendation: Pass the max_lessons_per_scope config value to LessonManager constructor and use it instead of the hardcoded MAX_LESSONS constant. For example, modify Runtime.create() to pass config.lessons.max_lessons_per_scope when creating the LessonManager.
Was this helpful? React with 👍 or 👎 to provide feedback.
Uh oh!
There was an error while loading. Please reload this page.