8000 [222_54]: Changed graphical selection from blue fill to black border(#2963) by Hendrixx-RE · Pull Request #2970 · MoganLab/mogan · GitHub
[go: up one dir, main page]

Skip to content

[222_54]: Changed graphical selection from blue fill to black border(#2963)#2970

Open
Hendrixx-RE wants to merge 3 commits intoMoganLab:mainfrom
Hendrixx-RE:fix-graphics-selection-2963
Open

[222_54]: Changed graphical selection from blue fill to black border(#2963)#2970
Hendrixx-RE wants to merge 3 commits intoMoganLab:mainfrom
Hendrixx-RE:fix-graphics-selection-2963

Conversation

@Hendrixx-RE
Copy link
@Hendrixx-RE Hendrixx-RE commented Mar 10, 2026

Fixes #2963

Problem:

Currently, when a user clicks or selects a graphics canvas, the editor applies a semi-transparent blue fill over the entire area. On large canvases or complex drawings, this fill obscures the content and makes it difficult to see the grid or the objects being edited.

Solution:

This PR modifies the rendering logic to provide a cleaner, non-intrusive "hollow" selection border for graphics environments while maintaining standard behavior for text and tables.

Key Changes:

  1. Modified src/Edit/Interface/edit_repaint.cpp to check if the current selection is inside_active_graphics().
  2. If true, the standard selection fill is bypassed.
  3. Implemented a manual 4-line border drawing using ren->line based on the rectangle's bounding coordinates (x1, y1, x2, y2).
  4. Included developer documentation in devel/222_54.md.

Before:
560015867-2f1d914b-c1ea-43fd-823d-02dc9f60f287

After:
260311_03h10m15s_screenshot

@Hendrixx-RE Hendrixx-RE changed the title [202_112]: Changed graphical selection from blue fill to black border(#2963) [222_112]: Changed graphical selection from blue fill to black border(#2963) Mar 10, 2026
@Hendrixx-RE Hendrixx-RE changed the title [222_112]: Changed graphical selection from blue fill to black border(#2963) [222_54]: Changed graphical selection from blue fill to black border(#2963) Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

光标处于环境的效果目前是背景高亮,但在一些环境时应该使用边框

1 participant

0