8000 Features/nullable friendly by nzaugg · Pull Request #8 · MindfireTechnology/EFRepository · GitHub
[go: up one dir, main page]

Skip to content

Features/nullable friendly#8

Merged
legacybass merged 4 commits intomasterfrom
Features/nullable-friendly
Jan 13, 2022
Merged

Features/nullable friendly#8
legacybass merged 4 commits intomasterfrom
Features/nullable-friendly

Conversation

@nzaugg
Copy link
Contributor
@nzaugg nzaugg commented Jan 12, 2022

No description provided.

@nzaugg nzaugg requested a review from legacybass January 12, 2022 22:49
* Adding NullReferenceException being thrown if query is null
* Added Support for Nullable value types
* Enhanced the README.md file
Copy link
Contributor
@legacybass legacybass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

/// <summary>
/// Filter the <see cref=""IQueryable""/> of {dbSetClass.Name} by {memberName} greater than or equal value
/// </summary>
/// <param name=""value"">The {type} which should be greater than {memberName}</param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor complaint, but this comment should say "greater than or equal to {memberName}"

@legacybass legacybass merged commit d0157a6 into master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0