Add missing public init to StackOrchestrator.FetchResource
#225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 94.97% 94.98%
=======================================
Files 97 97
Lines 3263 3267 +4
=======================================
+ Hits 3099 3103 +4
Misses 164 164
Continue to review full report at Codecov.
|
nbarreto6
approved these changes
Nov 13, 2020
JOCuendet
approved these changes
Nov 13, 2020
p4checo
approved these changes
Nov 13, 2020
Collaborator
There was a problem hiding this comment.
Thanks for this! Days since I forgot a public init: 0 😅
diogoeiras
approved these changes
Nov 13, 2020
nqtavares
approved these changes
Nov 13, 2020
- Add missing newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
StackOrchestrator.FetchResourceis missing itspublic initonly having the synthesized internalinit.Description
StackOrchestrator.FetchResourceneeds to be inited as it's the typealias forStackOrchestratorStore.Resourceand necessary as a parameter onStackOrchestratorStore.fetch(resource:completion:). No helpers or alternative methods seem to be available for instantiating the struct so the absence of the explicitinitis most likely an oversight.