Add YAxisAnchors to baseline autolayout helpers #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
+ Coverage 94.84% 94.95% +0.10%
==========================================
Files 97 97
Lines 3200 3248 +48
==========================================
+ Hits 3035 3084 +49
+ Misses 165 164 -1
Continue to review full report at Codecov.
|
filipe-lemos
approved these changes
Oct 23, 2020
ricardomsm
approved these changes
Oct 23, 2020
p4checo
approved these changes
Oct 23, 2020
Collaborator
There was a problem hiding this comment.
Great stuff! 👏
Just some minor code styling nitpicks 🚓
Tests/AlicerceTests/AutoLayout/BottomConstrainableProxyTestCase.swift
Outdated
Show resolved
Hide resolved
diogoeiras
approved these changes
Oct 23, 2020
literallysofia
approved these changes
Oct 23, 2020
46aeae7 to
c52bd3d
Compare
nbarreto6
pushed a commit
that referenced
this pull request
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
masterMotivation and Context
Complementing our Autolayout API with YAxisAnchors to BaselineAnchors helpers.
Description
Added helpers for top\bottom\centerY anchors to first\last BaselineAnchors.
Tested by applying the helper functions to two views and asserting the resulting constraint was equal to the expected.